Added preview and migration API endpoints for route migration from regex into jinja2 #1715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…filtering_term_type" This reverts commit c27b8dd.
|
Reverted "adding new field and data migration" as might be incompatible change for our api and terraform. I decided to make migrations manual |
…inja2 action to route on private api
iskhakov
force-pushed
the
iskhakov/migrate-regex-routes-to-jinja2
branch
from
dba067a
to
f9473f2
Compare
iskhakov
changed the title
iskhakov
changed the title
iskhakov
changed the title
iskhakov
added
pr:no changelog
pr:no public docs
Konstantinov-Innokentii
approved these changes
Apr 18, 2023
iskhakov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR adds new API endpoints for migrating routes from regex format to jinja2 format. The changes include the following:
filtering_term_as_jinja2field to GETchannels_filtersendpointchannel_filters/ABCDEF123/convert_from_regex_to_jinja2/for migrating routes to jinja2 format.These new endpoints will allow users to preview and migrate their existing regex routes to the more flexible and maintainable jinja2 format.
Check the screenshot where this endpoints will be used
Which issue(s) this PR fixes
Checklist
pr:no public docsPR label added if not required)CHANGELOG.mdupdated (orpr:no changelogPR label added if not required)